Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fix Topology node state filter #17940

Merged
merged 2 commits into from
Jul 19, 2023
Merged

ui: fix Topology node state filter #17940

merged 2 commits into from
Jul 19, 2023

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Jul 13, 2023

"Ineligible" and "Draining" are not determined by the node status, but are rather inferred from other fields.

Closes #17772

"Ineligible" and "Draining" are not determined by the node status, but
are rather inferred from other fields.
@lgfa29 lgfa29 added this to the 1.6.x milestone Jul 13, 2023
@lgfa29 lgfa29 added backport/1.4.x backport to 1.4.x release line backport/1.5.x backport to 1.5.x release line backport/1.6.x backport to 1.6.x release line labels Jul 13, 2023
@lgfa29 lgfa29 requested a review from philrenaud July 13, 2023 18:15
Copy link
Contributor

@philrenaud philrenaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @lgfa29 !

@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Ember Test Audit comparison

main 30425d3 change
passes 1496 1496 0
failures 1 1 0
flaky 0 0 0
duration 000ms 000ms -000ms

@lgfa29 lgfa29 merged commit 969ea54 into main Jul 19, 2023
20 of 21 checks passed
@lgfa29 lgfa29 deleted the b-ui-fix-topo-node-state branch July 19, 2023 20:38
lgfa29 added a commit that referenced this pull request Jul 19, 2023
"Ineligible" and "Draining" are not determined by the node status, but
are rather inferred from other fields.
lgfa29 added a commit that referenced this pull request Jul 19, 2023
"Ineligible" and "Draining" are not determined by the node status, but
are rather inferred from other fields.
lgfa29 added a commit that referenced this pull request Jul 19, 2023
"Ineligible" and "Draining" are not determined by the node status, but
are rather inferred from other fields.

Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
lgfa29 added a commit that referenced this pull request Jul 19, 2023
"Ineligible" and "Draining" are not determined by the node status, but
are rather inferred from other fields.

Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
jrasell pushed a commit that referenced this pull request Jul 26, 2023
"Ineligible" and "Draining" are not determined by the node status, but
are rather inferred from other fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.4.x backport to 1.4.x release line backport/1.5.x backport to 1.5.x release line backport/1.6.x backport to 1.6.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inelligible filter in topology doens't work
2 participants