Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return HTTP status code 501 Not Implemented on rpc: can't find service errors #18050

Open
lgfa29 opened this issue Jul 24, 2023 · 0 comments
Open

Return HTTP status code 501 Not Implemented on rpc: can't find service errors #18050

lgfa29 opened this issue Jul 24, 2023 · 0 comments
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/api HTTP API and SDK issues type/enhancement

Comments

@lgfa29
Copy link
Contributor

lgfa29 commented Jul 24, 2023

Proposal

When a Nomad region forwards a request to a region running an older version of Nomad that doesn't implement the given RPC endpoint, the rpc stdlib returns rpc: can't find service which is wrapped in a 500 Internal Server Error HTTP response but a better result would be a 501 Not Implemented that can be better handled by consumers.

Use-cases

Better determine if a request error is caused by an endpoint not being implemented.

Attempted Solutions

String match the rpc: can't find service error message.
@lgfa29 lgfa29 added type/enhancement theme/api HTTP API and SDK issues stage/accepted Confirmed, and intend to work on. No timeline committment though. labels Jul 24, 2023
@lgfa29 lgfa29 mentioned this issue Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/api HTTP API and SDK issues type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lgfa29