Allow omitting resource block entirely #1864
Conversation
| @@ -2103,7 +2103,9 @@ func (t *Task) Canonicalize(job *Job, tg *TaskGroup) { | |||
| service.Canonicalize(job.Name, tg.Name, t.Name) | |||
| } | |||
|
|
|||
| if t.Resources != nil { | |||
| if t.Resources == nil { | |||
| @@ -40,6 +40,7 @@ BUG FIXES: | |||
| the client [GH-1641] | |||
| * discovery/jobspec: Validate service name after interpolation [GH-1852] | |||
| * driver/docker: Fix `local/` directory mount into container [GH-1830] | |||
| * jobspec: Tasks without a resource block no longer fail to validate [GH-1864] | |||
There was a problem hiding this comment.
... and they will apply a default resource constraint of $x CPU and $y RAM ?
There was a problem hiding this comment.
Yes! Honestly this change is probably only useful for testing as the defaults really aren't intended to fit real world workflows.
There was a problem hiding this comment.
would be nice if nomad could emit plan/run warnings saying "you did stupid shit, stop doing it, but i will do it anyway since I'm a cool nomad scheduler"
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
No description provided.