Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: ensure HCL env vars are added to the job submission object. #18832

Merged
merged 3 commits into from
Oct 24, 2023
Merged

cli: ensure HCL env vars are added to the job submission object. #18832

merged 3 commits into from
Oct 24, 2023

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Oct 23, 2023 •
edited
Loading

closes #18805

@jrasell jrasell self-assigned this Oct 23, 2023
@jrasell jrasell added the backport/1.6.x backport to 1.6.x release line label Oct 23, 2023
@jrasell jrasell marked this pull request as ready for review October 23, 2023 09:01
shoenig
shoenig reviewed Oct 23, 2023
View reviewed changes
command/helpers_test.go Outdated Show resolved Hide resolved
gulducat
gulducat approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

command/helpers.go Show resolved Hide resolved
command/helpers_test.go Outdated Show resolved Hide resolved
@jrasell jrasell requested review from shoenig and gulducat October 24, 2023 07:46
shoenig
shoenig approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jrasell jrasell merged commit f64ade2 into main Oct 24, 2023
@jrasell jrasell deleted the b-gh-18805 branch October 24, 2023 15:48
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Oct 24, 2023
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoenig shoenig shoenig approved these changes

@gulducat gulducat gulducat approved these changes

@philrenaud philrenaud Awaiting requested review from philrenaud

Assignees

@jrasell jrasell

Labels
backport/1.6.x backport to 1.6.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display all provided variables in UI
3 participants
@jrasell @shoenig @gulducat