Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag api submodule #19613

Open
IamTheFij opened this issue Jan 4, 2024 · 1 comment
Open

Tag api submodule #19613

IamTheFij opened this issue Jan 4, 2024 · 1 comment
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/api HTTP API and SDK issues theme/build-infrastructure type/enhancement

Comments

@IamTheFij
Copy link
Contributor

Proposal

The Nomad API is used in a number of other projects (Traefik, Diun, Prometheus, etc...) however the module github.com/hashicorp/nomad/api has no tagged versions. Is it possible to create release tags for the API? An api/v1.7.2 tag would be great, but it is probably worth some policy on when to tag an API module release.

Use-cases

Building projects dependent on Nomad API without having to pin shas.

Attempted Solutions

Pinning specific shas

@tgross tgross added this to Needs Triage in Nomad - Community Issues Triage via automation Jan 5, 2024
@jrasell
Copy link
Member

jrasell commented Jan 9, 2024

Hi @IamTheFij and thanks for raising this issue. Tagging the API sub-module is something we have discussed internally and there is a desire to do this. I can't quite remember the details, but there are a couple of items we would need to sort and figure out first before we would be able to do this.

Currently to find the commit of a tagged released the command git rev-list -n 1 <version can be used. The SHA returned can then be used within the go get command.

@jrasell jrasell added theme/api HTTP API and SDK issues theme/build-infrastructure stage/accepted Confirmed, and intend to work on. No timeline committment though. labels Jan 9, 2024
@jrasell jrasell moved this from Needs Triage to Needs Roadmapping in Nomad - Community Issues Triage Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/api HTTP API and SDK issues theme/build-infrastructure type/enhancement
Projects
Status: Needs Roadmapping
Development

No branches or pull requests

2 participants