Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor agent.Config to maintain user config vs normalized settings #1971

Closed
schmichael opened this issue Nov 10, 2016 · 1 comment
Closed

Comments

@schmichael
Copy link
Member

Nomad currently alters agent.Config in various places to normalize/autodetect various settings.

  • agent/Config.normalizeAddrs changes advertise addresses based on a number of factors
  • agent/Command.readConfig sets a few defaults

Ideally the original config would be maintained as-is and normalized/derived settings would either be in internal configs like nomad.Config or at least on unexported fields on the agent config.

@schmichael schmichael self-assigned this Nov 10, 2016
@dadgar dadgar added this to the v0.5.1 milestone Nov 10, 2016
@tgross tgross removed this from the near-term milestone Jan 9, 2020
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants