Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use net.JoinHostPort instead of fmt.Sprintf #2036

Merged
merged 2 commits into from
Nov 28, 2016
Merged

Use net.JoinHostPort instead of fmt.Sprintf #2036

merged 2 commits into from
Nov 28, 2016

Conversation

schmichael
Copy link
Member

Using fmt.Sprintf breaks IPv6 addresses.

@schmichael
Use net.JoinHostPort instead of fmt.Sprintf
4eb3002 
Using fmt.Sprintf breaks IPv6 addresses.
@dadgar
Copy link
Contributor

dadgar commented Nov 28, 2016

Add to changelog please when merged

@schmichael schmichael merged commit 8983918 into master Nov 28, 2016
@schmichael schmichael deleted the b-fix-host-port-joining branch November 28, 2016 18:58
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dadgar dadgar dadgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schmichael @dadgar