Ensuring allocs are not added multiple times to blocking queue #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadgar
approved these changes
Nov 29, 2016
| // Check if the alloc is already present in the blocked allocations | ||
| // map | ||
| if _, ok := c.blockedAllocations[add.PreviousAllocation]; !ok { | ||
| c.logger.Printf("[DEBUG] client: added alloc %q to blocked queue", add.ID) |
There was a problem hiding this comment.
Can you print the PreviousAllocation to help with debugging
diptanu
force-pushed
the
b-block-allocs
branch
from
ca237e6
to
2e058f3
Compare
diptanu
force-pushed
the
b-block-allocs
branch
from
2e058f3
to
9100497
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.