-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
artifact {} with custom destination does not work as advertised #2092
Comments
Hey destination is relative to the allocation directory. It is not absolute. Please see the documentation: https://www.nomadproject.io/docs/job-specification/artifact.html#destination Agree that it should do a rename rather than a join. |
@dadgar know it's "relative" :) the only problem is the destination is really just the directory, so end result is |
@jippi This isn't really possible with the API of go-getter. It assumes destination is a folder, just dug into the API. The only way to do this is to introduce a new option in the artifact block |
Talked in Gitter, but following up. Added better documentation in this commit: 30655ef I want to avoid a special flag and until a very compelling case comes up, the docs should suffice. |
@dadgar seems legit to me ! thank you |
I stumbled upon this same issue today. In my opinion, not able to specify the file name, enforces an artificial constraint on the user. I had imagined that I would be able to keep various config files together in my S3 bucket, and based on some option, be able to pick any one from the S3 bucket and save it with a common name in the destination. Being able to name the destination file seemed obvious to me. Hope this gets implemented.
Regards, |
Pretty sure this is fixed in next release as go-getter now support file mode :) |
FWIW, I am using version Could you point me to the place where go-getter mentions how to set target as a file ? Regards, |
I think #2781 is what you are looking for |
@jippi Thanks, Got it! 👍 Regards, |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Nomad version
0.5.1-rc1
Operating system and Environment details
Linux Debian 7.9
Issue
Based on the docs
should create
/tmp/example.txt
, though adjusting it to my own paths like below, this is not the caseIt actually created
/server/local/php-fpm.conf/php-fpm.ctmpl
instead. Thus using thedestination
as a directory (ignoring the file part) and putting the file inside thedestination
directory as-named on thesource
urlThe text was updated successfully, but these errors were encountered: