Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeName on telemetry #2094

Closed
jorgemarey opened this issue Dec 13, 2016 · 3 comments
Closed

NodeName on telemetry #2094

jorgemarey opened this issue Dec 13, 2016 · 3 comments

Comments

@jorgemarey
Copy link
Contributor

Hi!

I configured nomad to send metris to statsd. I was expecting the metric to contain the nodename I set on the configuration, but instead the hostname was sent. I saw that is the go-metrics package the one that picks the hostname and set that value on each metric (https://github.com/hashicorp/nomad/blob/master/vendor/github.com/armon/go-metrics/start.go#L48)

I don't know if it is possible to change that value to use the nodename (or if this makes sense).

I think that just inserting metricsConf.HostName = config.NodeName on https://github.com/hashicorp/nomad/blob/master/command/agent/command.go#L624 should be enought to change the behaviour.

I could do a PR if you agree with this.

@dadgar
Copy link
Contributor

dadgar commented Dec 13, 2016

Seems reasonable! We would welcome a PR for this. To be clear it would be a boolean option setting host name to node name

@jorgemarey
Copy link
Contributor Author

Great! I'll do the PR.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants