Nomad Constructor Jobs and Dispatch #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the generated name to timestamp + 8 characters of UUID Add Snappy compression to the input
Children object is always initialized instead of lazily. `nomad status` outputs children summaries and has specialized view for constructor jobs.
jippi
reviewed
Dec 19, 2016
| } | ||
| alloc.Job.Constructor = &structs.ConstructorConfig{} | ||
|
|
||
| // Add an encrypted payload |
There was a problem hiding this comment.
is it encrypted? isn't snappy a compression library?
|
|
||
| func (c *JobDispatchCommand) Help() string { | ||
| helpText := ` | ||
| Usage: nomad job dispatch [options] <constructor> [input source] |
|
|
||
| // Check that we got exactly one node | ||
| args = flags.Args() | ||
| if l := len(args); l < 1 || l > 2 { |
There was a problem hiding this comment.
why this logic rather than l != 1 ?
There was a problem hiding this comment.
It can be one or two but no less and no more :)
There was a problem hiding this comment.
the comment says "exactly one node" ? :)
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces:
nomad dispatchcommand and API to create an instance of a constructor job.