Filter executor log messages #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptanu
force-pushed
the
b-executor-log-level
branch
from
9c92fdf
to
1470d4e
Compare
dadgar
reviewed
Jan 12, 2017
| filter := &logutils.LevelFilter{ | ||
| Levels: []logutils.LogLevel{"TRACE", "DEBUG", "INFO", "WARN", "ERR"}, | ||
| MinLevel: logutils.LogLevel(strings.ToUpper(logLevel)), | ||
| Writer: ioutil.Discard, |
There was a problem hiding this comment.
Doesn't the Discard make all logs disappear
| Writer: ioutil.Discard, | ||
| } | ||
|
|
||
| e.logger = log.New(filter, "", log.LstdFlags) |
There was a problem hiding this comment.
log.New(logOutput, "", log.LstdFlags|log.Lmicroseconds) to be like the client. Easier to correlate stuff when debugging
| if len(args) == 0 { | ||
| e.Ui.Error("log output file isn't provided") | ||
| if len(args) != 1 { | ||
| e.Ui.Error("log output file and log level are not provided") |
There was a problem hiding this comment.
"json configuration not provided"
diptanu
force-pushed
the
b-executor-log-level
branch
from
1470d4e
to
a066d90
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Tests needs to be fixed. PR for running tests on Travis.
Fixes #2106