Support setting class_path and class name. #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enhances the java driver to allow setting the class path and class name to run. It also fixes an issue that would make the Java driver attempt to chroot regardless of operating system (this never effected a released version of Nomad).
schmichael
approved these changes
Jan 14, 2017
| import cstructs "github.com/hashicorp/nomad/client/structs" | ||
|
|
||
| func (d *JavaDriver) FSIsolation() cstructs.FSIsolation { | ||
| return cstructs.FSIsolationNone |
| @@ -1,7 +1,7 @@ | |||
| public class Hello { | |||
| public static void main(String[] args) { | |||
| while (true) { | |||
| System.out.println("Hi"); | |||
| System.out.println("Hello"); | |||
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the java driver to allow setting the class path and
class name to run. It also fixes an issue that would make the Java
driver attempt to chroot regardless of operating system (this never
effected a released version of Nomad).