Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from using cgroups BlkioThrottleReadIOpsDevice to BlkioWeight #222

Merged
merged 2 commits into from
Oct 6, 2015

Conversation

cbednarski
Copy link
Contributor

Fixes #220

@dadgar
Copy link
Contributor

dadgar commented Oct 6, 2015

This is not quite right. We were doing blkio wrong: https://www.kernel.org/doc/Documentation/cgroups/blkio-controller.txt

It has to be device_major:device_minor:limit.

Alternatively we can use BlkioWeight. I think this is the better route to take as it applies across devices.

…kes a list of ThrottleDevice structs instead of an int
@dadgar dadgar changed the title Updated Throttle Read/Write to match upstream changes in runc; now takes a list of ThrottleDevice structs instead of an int Switch from using cgroups BlkioThrottleReadIOpsDevice to BlkioWeight Oct 6, 2015
dadgar added a commit that referenced this pull request Oct 6, 2015
Switch from using cgroups BlkioThrottleReadIOpsDevice to BlkioWeight
@dadgar dadgar merged commit d31d621 into master Oct 6, 2015
@dadgar dadgar deleted the b-runc-throttle-device branch October 6, 2015 22:47
@dadgar
Copy link
Contributor

dadgar commented Oct 6, 2015

BlkioThrottleReadIOpsDevice lets you specify an IOPs limit per device in a cgroup while BlkioWeight applies to all devices and is not a raw IOPs value but rather a weight similar to how cgroups handles CPU. This means under low contention process will have more access to disk and under contention they will be limited correctly.

We are switching to this because it is a more desirable behavior and we don't need to set up cgroups per disk device.

@github-actions
Copy link

github-actions bot commented May 8, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants