Locking appropriately before closing the channel to indicate migration #2231
Conversation
| // migrateAllocCtrl indicates whether migration is complete | ||
| type migrateAllocCtrl struct { | ||
| ch chan struct{} | ||
| chLock sync.Mutex |
| m.chLock.Lock() | ||
| defer m.chLock.Unlock() | ||
|
|
||
| // If channel is not closed then close it |
There was a problem hiding this comment.
m.chLock.Lock()
defer m.chLock.Unlock()
if m.closed {
return
}
m.closed = true
close(m.ch)
There was a problem hiding this comment.
The current implementation will actually block
There was a problem hiding this comment.
Yeah it doesn't block and return false immediately when the ch is closed.
| } | ||
|
|
||
| func (m *migrateAllocCtrl) closeCh() { | ||
| m.chLock.Lock() |
There was a problem hiding this comment.
I don't think you need this lock as runAllocs method is only ever called from a single goroutine so all chan mutations are serialized.
There was a problem hiding this comment.
It might be called concurrently though.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #2230