Making GC related fields tunable #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmichael
approved these changes
Jan 31, 2017
| @@ -53,6 +53,9 @@ client { | |||
| data_points = 35 | |||
| collection_interval = "5s" | |||
| } | |||
| gc_interval = "6s" | |||
| gc_disk_usage_threshold = 82 | |||
| gc_inode_usage_threshold = 91 | |||
dadgar
requested changes
Jan 31, 2017
| @@ -151,6 +151,18 @@ type Config struct { | |||
| // TLSConfig holds various TLS related configurations | |||
| TLSConfig *config.TLSConfig | |||
|
|
|||
| // GCInterval is the time interval at which the client triggers garbage | |||
| // collection | |||
| GCInterval time.Duration | |||
diptanu
force-pushed
the
f-gc-threshold
branch
from
7e74f83
to
6b0a1eb
Compare
dadgar
approved these changes
Feb 1, 2017
|
@diptanu will this allow me to configure nomad to not wipe any allocations before, say, 24h ? |
|
@jippi Nope this just allows picking at what disk usage percentage GC kicks in |
|
@dadgar okay, i really want to be able to extend the disk GC to be more than 4h, more than once i've lost template or logs for debugging :) |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.