Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a task event for setup #2302

Merged
merged 2 commits into from
Feb 23, 2017
Merged

Adding a task event for setup #2302

merged 2 commits into from
Feb 23, 2017

Conversation

diptanu
Copy link
Contributor

@diptanu diptanu commented Feb 10, 2017

No description provided.

@dadgar
Copy link
Contributor

dadgar commented Feb 10, 2017

LGTM but need to add docs: https://www.nomadproject.io/docs/http/alloc.html#TaskStates

@dadgar
Copy link
Contributor

dadgar commented Feb 10, 2017

Fix tests.

@@ -2769,6 +2769,13 @@ const (
// failed.
TaskArtifactDownloadFailed = "Failed Artifact Download"

// TaskBuildingTaskDir indicates that the task direcotry/chroot is being
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

direcotry => directory

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nanoz! Fixed in master

@dadgar dadgar merged commit c89d824 into master Feb 23, 2017
@dadgar dadgar deleted the f-task-state-setup branch February 23, 2017 02:43
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants