Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nomad operator command for interacting with Raft configuration #2305

Merged
merged 10 commits into from
Feb 14, 2017

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Feb 10, 2017

This PR adds:

  • nomad operator raft list-peers and nomad operator raft remove-peer subcommands
  • Corresponding endpoints
  • A guides section to our website
  • Moves bootstrapping to guides from docs
  • Adds an outage recovery guide.

@sethvargo For guidance on redirects from the old bootstrap page

Copy link
Contributor

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @dadgar.

It seems like docs/cluster -> guides/cluster. Are there any other redirects?

## Usage

```
nomad operator raft list-peers [options]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the other pages have that.

nomad-server03.global 10.10.11.7:4647 10.10.11.7:4647 follower true
```

* `Node` is the node name of the server, as known to Nomad, or "(unknown)" if
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, itd be great if we could use - instead of * for bullets.

## Usage

```
nomad operator raft remove-peer [options]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$

all Raft log entries, so should only be used to recover from an outage, but it
should allow recovery from any situation where there's some cluster data available.

<a name="peers.json"></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to do this - there will be an automatic <a> link generated as #manual-recovery-using-peers.json

requires an operator to intervene, but the process is straightforward.

~> This guide is for recovery from a Nomad outage due to a majority
of server nodes in a datacenter being lost. If you are just looking to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "just"


```javascript
[
"10.0.1.8:4647",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two space before all these strings

@dadgar
Copy link
Contributor Author

dadgar commented Feb 14, 2017

@sethvargo Yeah docs/cluster -> guides/cluster is the only redirect! Thanks for review

@sethvargo
Copy link
Contributor

@dadgar perfect - ping me once these changes are out (can't put it out until then) and we'll get the redirs in place

@dadgar dadgar merged commit d0cc49d into master Feb 14, 2017
@dadgar dadgar deleted the f-operator branch February 14, 2017 19:01
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants