Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Volume Drivers #2351

Merged
merged 2 commits into from
Feb 23, 2017
Merged

Conversation

pietromenna
Copy link
Contributor

This commit adds the functionality to use Docker Volume Drivers.

This commit adds the functionality to use Docker Volume Drivers.
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM other than some minor doc cleanups.

# Use named volume created outside nomad.
"name-of-the-volume:/path/in/container"
]
volume_driver = "flocker"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment to draw attention to the volume_driver field being described.

"/path/on/host:/path/in/container",

# Use relative paths to rebind paths already in the allocation dir
"relative/to/task:/also/in/container",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these other examples that are already included above as I think the name-of-the-volume example is the important one when showing how to use volume_driver

@pietromenna
Copy link
Contributor Author

Hi @schmichael ,

I just incorporated the changes you suggested.

Thanks!

@schmichael
Copy link
Member

Perfect! Thanks!

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants