A raw fork/exec driver that provides no isolation. #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| func (d *RawExecDriver) Fingerprint(cfg *config.Config, node *structs.Node) (bool, error) { | ||
| // Check that the user has explicitly enabled this executor. | ||
| enabled := strings.ToLower(cfg.ReadDefault(rawExecConfigOption, "false")) | ||
| if enabled == "1" || enabled == "true" { |
There was a problem hiding this comment.
This should use strconv.ParseBool.
There was a problem hiding this comment.
Nice I didn't know about this 👍
|
A few minor comments, but LGTM! |
dadgar
added a commit
that referenced
this pull request
Oct 9, 2015
A raw fork/exec driver that provides no isolation.
|
nice - is there an ETA for a binary release with this included? |
|
@jippi This will come out in 0.2.0 but we don't have a release date yet. If you'd like to try this out in advance you can build from master. |
benbuzbee
pushed a commit
to benbuzbee/nomad
that referenced
this pull request
Jul 21, 2022
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A raw fork/exec driver that provides no isolation.
Addresses #213