-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: quota status extension for devices #23899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM code-wise.
It's a little odd from a semantics perspective though, because devices aren't fungible between each other in the way memory and CPU are. Consider a region limit with 2 devices A (limit 3) and B (limit 4). All the following combinations of usage get written as 4 / 7
: A0 + B4, A1 + B3, A2 + B2, A3 + B1, A4 + B0. It's not debuggable here what device usage is causing the limit.
Maybe we should have a separate listing of per-device quotas?
0919952
to
22cf5a7
Compare
I hear this. Refactored in 22cf5a7. Example output:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This
quota status
CLI extension aggregates over all devices that are part of a quota and lists their usage/limit.