Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: quota status extension for devices #23899

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

pkazmierczak
Copy link
Contributor

This quota status CLI extension aggregates over all devices that are part of a quota and lists their usage/limit.

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise.

It's a little odd from a semantics perspective though, because devices aren't fungible between each other in the way memory and CPU are. Consider a region limit with 2 devices A (limit 3) and B (limit 4). All the following combinations of usage get written as 4 / 7: A0 + B4, A1 + B3, A2 + B2, A3 + B1, A4 + B0. It's not debuggable here what device usage is causing the limit.

Maybe we should have a separate listing of per-device quotas?

@pkazmierczak
Copy link
Contributor Author

Maybe we should have a separate listing of per-device quotas?

I hear this. Refactored in 22cf5a7. Example output:

Name        = default-quota
Description = Limit the shared default namespace
Limits      = 2

Quota Limits
Region  CPU Usage  Core Usage  Memory Usage  Memory Max Usage  Variables Usage
eu      - / 3500   - / 2       - / 2000      - / 2000          - / inf
global  0 / 2500   0 / inf     0 / 1000      0 / 1000          0 / 1000

Quota Device Limits
Region  Device Name        Device Usage
eu      nvidia/gpu/1080ti  - / 2
global  nvidia/gpu/1080ti  1 / 1

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkazmierczak pkazmierczak merged commit 47f3313 into main Sep 12, 2024
8 of 9 checks passed
@pkazmierczak pkazmierczak deleted the f-quota-status-device branch September 12, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants