Ensure dev/, proc/, and alloc/ are mounted every time a task is run #2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If they're unmounted by a reboot they'll be properly remounted.
dadgar
approved these changes
Mar 2, 2017
client/allocdir/fs_linux.go
Outdated
| @@ -30,8 +30,15 @@ func linkDir(src, dst string) error { | |||
|
|
|||
| // unlinkDir unmounts a bind mounted directory as Linux doesn't support | |||
| // hardlinking directories. | |||
| // | |||
There was a problem hiding this comment.
Nit pick but can you just add that to the existing comment. No need for extra line
client/allocdir/task_dir.go
Outdated
| // Build default directories and permissions in a task directory. If the built | ||
| // boolean is true Build assumes the task dir has already been built and skips | ||
| // expensive operations like chroot creation. | ||
| func (t *TaskDir) Build(built bool, chroot map[string]string, fsi cstructs.FSIsolation) error { |
There was a problem hiding this comment.
I don't like built since you wouldn't call Build if that is true. Can it be chrootCreated
client/allocdir/task_dir.go
Outdated
| // Link/copy chroot entries | ||
| if err := t.embedDirs(entries); err != nil { | ||
| return err | ||
| // |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since mounts disappear on reboot, ensure everything is properly mounted every time a task starts.
This behavior was changed in #2132. Prior to that PR we rebuilt the entire task dir every time a task started.