Added insecure_options config list #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmichael
requested changes
Jun 7, 2017
client/driver/rkt.go
Outdated
| cmdArgs = append(cmdArgs, "--insecure-options=all") | ||
| } | ||
|
|
||
| // same for debug |
There was a problem hiding this comment.
It takes some reading to figure out the context for "same" so maybe just repeat the relevant comment here:
// debug is a global argument, so add it before "run"
| run with ```--insecure-options=all```. | ||
|
|
||
| * `insecure_options` - (Optional) List of insecure options for rkt. Consult ```rkt --help``` | ||
| for list of supported values. This list overrides the ```--insecure-options=all``` when |
There was a problem hiding this comment.
Single backticks around flags:
run with `--insecure-optionals=all`.
This list overrides the
--insecure-options=allwhen
should probably read:
This list overrides the
--insecure-options=alldefault when
|
Test failure is unrelated. Merging. Thanks for the contribution! |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #2026
While doing my proof-of-concepting, I see some usecases for --insecure-options=ondisk for example. Nevertheless, the options right now are either 'none' or 'all', this config will take precedence over the "rkt trust wasn't done", so one can instead of just omiting trust_prefix (and losing all secure options) specify insecure_options = ["image"].
It also makes it possible to enforce --insecure-options=none.
I've moved --debug as well, as both --debug and --insecure-options are rkt global parameters - made better sense.