-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimise occurrences of the log: [WARN] client: error fetching host disk usage stats
#2700
Comments
Hey @hmalphettes I would love a PR! It is probably worth logging the error only once on failure. We follow the pattern in the fingerprinters: https://github.com/hashicorp/nomad/blob/master/client/fingerprint/consul.go#L24 You can see it only logs failures on state changes! |
@dadgar thanks for the pointer. I'll find some time to do it then. If someone beats me to it, all the better. |
Doing some issue cleanup. Looks like this was fixed in 7a84cbe which shipped in 0.6.1 |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Nomad version
Nomad v0.5.6
Operating system and Environment details
CentOS Linux release 7.1
Issue
Every few seconds, nomad logs
Here is the PR where the log was introduced: #2090
Reproduction steps
Run nomad as a non privileged user.
Have a mounted partition where the user running nomad does not have read access.
Let me know if you need more specific steps: I did not setup that server.
Would you consider issuing the warning just once?
Should we in fact ignore a
permission denied
error all together: after all it makes sense that a non-privileged user does not monitor a partition it has no access to?I can attempt to contribute a PR if you want.
Let me know which way to go in that case.
Running nomad as a non-privileged user paired with the raw-exec driver is a less exciting setup nowadays. But it is a requirement for a vendor in a financial institution where security compliance relies entirely on running as a non-privileged user.
Many thanks for your attention!
The text was updated successfully, but these errors were encountered: