Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass task group name as NOMAD_GROUP_NAME environment variable #2877

Merged
merged 1 commit into from
Jul 20, 2017
Merged

Pass task group name as NOMAD_GROUP_NAME environment variable #2877

merged 1 commit into from
Jul 20, 2017

Conversation

kmalec
Copy link
Contributor

@kmalec kmalec commented Jul 20, 2017 •
edited by schmichael
Loading

Fixes #1943 which I found myself being useful.
Tested on real system:

# rkt enter 49cdd69b env | grep NOMAD_.*_NAME
NOMAD_GROUP_NAME=worker-group
NOMAD_JOB_NAME=worker
NOMAD_TASK_NAME=worker-task
NOMAD_ALLOC_NAME=worker.worker-group[0]

make test was complaining in my system, saw that master CI was also failing, so not sure how much that's related. Manual go test on ./client/driver was fine though. Let's see about CI on the PR.

schmichael
schmichael approved these changes Jul 20, 2017
View reviewed changes
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM

@schmichael schmichael merged commit c98104d into hashicorp:master Jul 20, 2017
schmichael added a commit that referenced this pull request Jul 21, 2017
@schmichael
Mention #2877 in changelog
3b422a9
@qkate qkate mentioned this pull request Jul 30, 2017
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmichael schmichael schmichael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kmalec @schmichael