Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs or behavior of Docker auth_soft_fail #3030

Closed
schmichael opened this issue Aug 15, 2017 · 1 comment · Fixed by #9393
Closed

Improve docs or behavior of Docker auth_soft_fail #3030

schmichael opened this issue Aug 15, 2017 · 1 comment · Fixed by #9393
Labels
theme/docs Documentation issues and enhancements theme/driver/docker type/enhancement

Comments

@schmichael
Copy link
Member

The existing behavior is to hard fail if Docker auth helpers are used but auth fails or the image isn't found. Users may set auth_soft_fail to fallback to the public Docker Hub on a per-job basis.

This creates a confusing scenario where users mixing public and private images have to set auth_soft_fail=true for every job using a public image iff Docker auth helpers are used.

Original comment: #2744 (comment)

this doesnt seem to be a global config option. setting this in every job configuration is fine but very confusing. A user would still have no idea what to do if an image simply doesn't download from dockerhub, and has no way to figure out that its from a global auth plugin. the docs don't say anything like "if you want to use public images in the same way as docker swarm or kubernetes, set auth_soft_fail".
maybe the config option should be "allow_dockerhub"

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/docs Documentation issues and enhancements theme/driver/docker type/enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant