Fix docker user specified syslogging

[dadgar]

Fixes #3182

[shantanugadgil]

Hi,
I did the following:

git checkout b-docker-logging
git pull
git log -p
make pkg/linux_amd64/nomad

Copied the binary to one of my client machines.
Logs appear correctly when I stop and start the service, but Nomad keep crashing upon startup.
Possibly related to #3188
(FWIW, I have stats reporting to a statsite enabled).

For now, I am reverting to version 0.6.2 GA

[dadgar]

@shantanugadgil can you build off of stable-v0.6.3 branch. Master isn't stable right now

[shantanugadgil]

just confirming; I too am seeing the same traceback:

2017/09/11 06:38:27 [INFO] (runner) creating new runner (dry: false, once: false)
fatal error: sync: RUnlock of unlocked RWMutex
goroutine 356 [running]:
runtime.throw(0x146faf6, 0x21)
...

@dadgar ok, I'll try building from stable-v0.6.3.

Q: But your syslog fix isn't merged to the branch stable-v0.6.3, right?

[dadgar]

You should be able to rebase it onto the stable branch or cherry pick the commit.

[dadgar]

Can you post the full stack trace as well! Thank you

[shantanugadgil]

nomad_0.6.3_traceback.txt

[shantanugadgil]

@dadgar I chery picked the single commit from b-docker-logging into stable-v0.6.3 and can see the logs on the central server correctly.

[shantanugadgil]

hi @dadgar @schmichael
this hasn't made its way into 0.6.3 GA right?
because I am seeing the same behavior with the 0.6.3 that I downloaded.
reverting to the file I have compiled myself works as expected with the logs appearing on the central server?

Regards,
Shantanu

[dadgar]

@shantanugadgil Ah shoot. I am sorry I forgot to cherry pick that commit into the branch! 0.7.0 will be out soon, sorry about that.

[shantanugadgil]

Thanks for the confirmation! Till 0.7.0 is out, I'll live with the file I have! 😄

[shantanugadgil]

Hi @dadgar
just wondering if this is in the 0.7.0 branch (?)
Asking as I didn't see it in the changelog
https://github.com/hashicorp/nomad/blob/master/CHANGELOG.md

waiting for 0.7.0 with much anticipation! 👏 👏 😁

[dadgar]

@shantanugadgil Added to changelog

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.