Add "distinctHost" constraint #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -237,6 +237,14 @@ The `constraint` object supports the following keys: | |||
| the attribute. This sets the operator to "regexp" and the `value` | |||
| to the regular expression. | |||
|
|
|||
| * `unique` - Unique accepts a boolean value and can be used to mark a Job or | |||
| a Task Group as requiring placement on unique nodes. If the `unique` | |||
| constraint is placed on a Job, all of it's Task Groups must be placed on | |||
There was a problem hiding this comment.
it's should not have an apostrophe
| * `distinctHosts` - `distinctHosts` accepts a boolean `true`. The default is | ||
| `false`. | ||
|
|
||
| When `distinctHosts is `true` at the Job level, each instance of all Task |
There was a problem hiding this comment.
Missing backtick on distinctHosts
| @@ -256,6 +257,20 @@ func parseConstraints(result *[]*structs.Constraint, obj *hclobj.Object) error { | |||
| m["RTarget"] = constraint | |||
| } | |||
|
|
|||
| if value, ok := m["distinctHosts"]; ok { | |||
|
LGTM other than changes |
Closed
benbuzbee
pushed a commit
to benbuzbee/nomad
that referenced
this pull request
Jul 21, 2022
Add leveled logging
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a distinctHost constraint that can be applied to either Task Groups or Jobs.