Reset evaluation Nack timer in response to scheduler operations #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
dadgar
added a commit
that referenced
this pull request
Oct 24, 2015
Reset evaluation Nack timer in response to scheduler operations
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the evaluations have a fixed Nack timeout period of 60 seconds. If they do not complete, the eval broker will always cause a Nack to happen. This is probably fine, except for under high contention or high load situations where its possible to exceed that timeout. This PR causes the Nack timer to be reset if the scheduler is submitting plans or modifying evaluations, as this still proves the liveness of the scheduler. It is still possible for an extremely slow scheduler to hit the Nack timeout, but this should make it much less likely.