-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent fully qualified URLs in check paths #3273
Comments
This wasn't actually fixed by the PR. It relies on IsAbs, which just checks the scheme. You can still override the ip/port like so:
|
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Nomad version
Nomad v0.6.3
Issue
HTTP checks can specify absolute URLs to query remote services. This overwrites the
port
andproto
parameters.The docs specify the intended behavior that only relative URLs are accepted. The current behavior is an unintentional side-effect of the underlying Go stdlib function we call: https://golang.org/pkg/net/url/#URL.ResolveReference
Job file (if appropriate)
The text was updated successfully, but these errors were encountered: