Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Vault default grace #3360

Merged
merged 5 commits into from
Oct 12, 2017
Merged

Use Vault default grace #3360

merged 5 commits into from
Oct 12, 2017

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Oct 12, 2017

This PR:

  • Changes the default vault_grace to match Vaults
  • Vendors consul-template

Fixes #3197

@dadgar dadgar merged commit b1e67a4 into master Oct 12, 2017
@dadgar dadgar deleted the f-consul-template branch October 12, 2017 01:11
jippi
jippi reviewed Oct 12, 2017
View reviewed changes
website/source/docs/job-specification/template.html.md
that is higher than your default TTL or max TTL, the template will always read
a new secret. If the task defines several templates, the `vault_grace` will be
set to the lowest value across all the templates.
- `vault_grace` `(string: "5m")` - Specifies the grace period between lease
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it 15m now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jippi jippi jippi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dadgar @jippi