Applies leader loop fixes from Consul. #3402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a deadlock issue we fixed under hashicorp/consul#3230, and then discovered an issue with under hashicorp/consul#3545. This PR ports over those fixes, as well as makes the revoke actions only happen if leadership was established. This brings the Nomad leader loop inline with Consul's.
|
I don't feel super confident in qualifying this change for Nomad, and I've had some trouble running all the unit tests locally (even without this change), but I thought a PR would be the best way to convey the changes Nomad ought to pull in based on the experience we had with Consul. Can y'all take a look at this one? |
dadgar
approved these changes
Nov 3, 2017
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a deadlock issue we fixed under hashicorp/consul#3230, and then discovered an issue with under hashicorp/consul#3545. This PR ports over those fixes, as well as makes the revoke actions only happen if leadership was established. This brings the Nomad leader loop inline with Consul's.