Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.7.0-rc3] prometheus telemetry keep emitting data for stopped allocations #3474

Closed
jippi opened this issue Oct 31, 2017 · 6 comments · Fixed by #3559
Closed

[0.7.0-rc3] prometheus telemetry keep emitting data for stopped allocations #3474

jippi opened this issue Oct 31, 2017 · 6 comments · Fixed by #3559

Comments

@jippi
Copy link
Contributor

jippi commented Oct 31, 2017

this is a DatsDog chart using prometheus to show nomad_client_allocs_memory_rss grouped by alloc_id - all those flat-lines are in fact allocations that is stopped, replaced by a new one (during a new submission of a job)

I've verified those allocation IDs still exist in /v1/metrics?format=prometheus when when the allocation is stopped/dead

Telemetry config:

disable_hostname: true,
publish_allocation_metrics: true
publish_node_metrics: true

image

@chelseakomlo
Copy link
Contributor

Thanks for reporting this issue- a task shouldn't emit events when it is dead. We have added this to our near-term roadmap.

@jippi
Copy link
Contributor Author

jippi commented Oct 31, 2017

personally i find it a pretty big bug, will make alerting etc seriously hard on the telemetry when stopped/dead allocations keep emitting the usage as if they are running, making 0.7 telemetry useless for cases like that :( i hope it can make it into 0.7-final considering this

@sirkjohannsen
Copy link

This bug is still present in 0.7.0 stable.
We used nomad-exporter (https://github.com/Nomon/nomad-exporter) before and were super happy to see that prometheus metrics now come out of the box... sadly this bug makes them unusable.

@jippi
Copy link
Contributor Author

jippi commented Nov 15, 2017

Is this target for next 0.7.* release?

@dadgar
Copy link
Contributor

dadgar commented Nov 16, 2017

@jippi Yep. PR is up

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants