Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add artifact_checksum to drivers #348

Closed
dadgar opened this issue Oct 27, 2015 · 6 comments
Closed

Add artifact_checksum to drivers #348

dadgar opened this issue Oct 27, 2015 · 6 comments
Assignees

Comments

@dadgar
Copy link
Contributor

dadgar commented Oct 27, 2015

Add an artifact_checksum that using the go-getter checksum feature: https://github.com/hashicorp/go-getter/pull/1/files

@armon
Copy link
Member

armon commented Oct 28, 2015

This may not be necessary after talking to @mitchellh, since the checksum can be a query parameter in artifact_source

@catsby
Copy link
Contributor

catsby commented Oct 28, 2015

Maybe we could support both? An explicit checksum type config option feels better to me, but I'm fine either way.

Regardless, I'll clean up the Qemu driver that does this on it's own, since it's now built into go-getter, and I'll make sure the other drivers behave as expected when a checksum is included

@dadgar
Copy link
Contributor Author

dadgar commented Oct 28, 2015

I could go either way. As long as we have a section in the docs documenting that you can add the checksum it is fine.

@catsby
Copy link
Contributor

catsby commented Nov 3, 2015

Proposing #381 as a fix

@dadgar
Copy link
Contributor Author

dadgar commented Nov 11, 2015

#381 fixes

@dadgar dadgar closed this as completed Nov 11, 2015
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants