[3503] adding consul-address flag to command.go #3504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-powis
force-pushed
the
fix_consul_address
branch
2 times, most recently
from
afc9d34
to
f559f7e
Compare
james-powis
force-pushed
the
fix_consul_address
branch
from
f559f7e
to
6d3cc25
Compare
|
OK this change should not have caused any tests to fail, going to leave it alone as it looks like the testing harness is to blame in some fashion... |
|
@james-powis Thanks for the PR and sorry that slipped through! |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the -consul-address flag while documented, was never actually implemented. This fix is not due to regression, but merely a miss on #3327
Closes #3503