Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove weight and hard/soft fields from constraint #351

Merged
merged 1 commit into from
Oct 28, 2015
Merged

Remove weight and hard/soft fields from constraint #351

merged 1 commit into from
Oct 28, 2015

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Oct 27, 2015

The constraints are becoming all hard constraints thus we don't need the boolean or the weight.

@armon
Copy link
Member

armon commented Oct 28, 2015

LGTM

dadgar added a commit that referenced this pull request Oct 28, 2015
@dadgar
Merge pull request #351 from hashicorp/f-clean-constraints
98185ca 
Remove weight and hard/soft fields from constraint
@dadgar dadgar merged commit 98185ca into master Oct 28, 2015
@dadgar dadgar deleted the f-clean-constraints branch October 28, 2015 17:51
@c4milo
Copy link
Contributor

c4milo commented Nov 18, 2015

does this mean Nomad allows oversubscription of resources or what's the reasoning for this change?

@dadgar
Copy link
Contributor Author

dadgar commented Nov 19, 2015

@c4milo: This change doesn't effect oversubscription. The reason for this change is that a soft constraint is really an affinity or anti-affinity. Currently we don't have any affinity/anti-affinity operators but the goal of this change was to make the distinction now so moving forward the messaging and code both are clear.

@c4milo
Copy link
Contributor

c4milo commented Nov 19, 2015

Nice! Thanks for explaining @dadgar!

benbuzbee pushed a commit to benbuzbee/nomad that referenced this pull request Jul 21, 2022
@tcarrio @schristoff
Fix broken link to Raft paper in README (hashicorp#347) and various l…
3a6687a 
…inting/formatting fixes (hashicorp#351)
@github-actions
Copy link

github-actions bot commented May 2, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dadgar @armon @c4milo