[Feature Request] Support StopTimeout for Docker tasks

[angrycub]

Would it be possible to support the StopTimeout field on Docker container creation?

re: ZD-5428

[samart]

Thanks.

To add color to this ticket -

Use case:

Operators may need to bounce docker engine, and engine will observe a stop-timeout if set on "docker run". This helps to ensure there is consistent stopping behavior when either nomad does a container stop and also docker-engine doing the stop. This helps protect applications that need a little more time to shutdown gracefully. Otherwise, the default that docker provides is just 10 seconds. When set, docker engine will wait the for the container that has the longest timeout.

Thank you!

[dadgar]

@samart Would you want this to be settable on its own or just be the same value as the kill_timeout. Have the two out of sync seems problematic.

[samart]

Hi Alex - it does make sense for it to be the same value and probably set automatically. But who knows if you will encounter the oddball use use where someone might see this as a problem.

But i am pro setting it automatically and that's a good feature IMHO.

[dadgar]

Will need fsouza/go-dockerclient#693 to merge first

[davidsylvester]

@chelseakomlo As part of which release this feature would be available ?

[dadgar]

It will be available shortly in 0.7.1

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.