-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Support StopTimeout for Docker tasks #3544
Comments
Thanks. To add color to this ticket - Use case: Operators may need to bounce docker engine, and engine will observe a stop-timeout if set on "docker run". This helps to ensure there is consistent stopping behavior when either nomad does a container stop and also docker-engine doing the stop. This helps protect applications that need a little more time to shutdown gracefully. Otherwise, the default that docker provides is just 10 seconds. When set, docker engine will wait the for the container that has the longest timeout. Thank you! |
@samart Would you want this to be settable on its own or just be the same value as the kill_timeout. Have the two out of sync seems problematic. |
Hi Alex - it does make sense for it to be the same value and probably set automatically. But who knows if you will encounter the oddball use use where someone might see this as a problem. But i am pro setting it automatically and that's a good feature IMHO. |
Will need fsouza/go-dockerclient#693 to merge first |
@chelseakomlo As part of which release this feature would be available ? |
It will be available shortly in 0.7.1 |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Would it be possible to support the StopTimeout field on Docker container creation?
re: ZD-5428
The text was updated successfully, but these errors were encountered: