Fix Docker name conflict bug by updating dockerclient #3551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fails on Docker 17.09, passes on Docker 17.06 and earlier
schmichael
force-pushed
the
b-3419-docker-409-bug
branch
from
4a01f1f
to
5f0f349
Compare
This was referenced Nov 15, 2017
preetapan
reviewed
Nov 15, 2017
| "revisionTime": "2017-11-14T19:25:14Z" | ||
| }, | ||
| { | ||
| "checksumSHA1": "mi8EDCDjtrZEONRXPG7VHJosDwY=", |
There was a problem hiding this comment.
do we really need swarm runtime?
There was a problem hiding this comment.
For some sad reason, yes:
[git:b-3419-docker-409-bug]~/go/src/github.com/hashicorp/nomad$ go list -f '{{ join .Deps "\n" }}' | grep swarm
github.com/hashicorp/nomad/vendor/github.com/docker/docker/api/types/swarm
github.com/hashicorp/nomad/vendor/github.com/docker/docker/api/types/swarm/runtime
dadgar
approved these changes
Nov 16, 2017
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3419
Replaces #3513
This is the fix we need from go-dockerclient: https://github.com/fsouza/go-dockerclient/blob/99ba9a9ff48803e4bf801b025c6be7707d83c421/container.go?utf8=%E2%9C%93#L634-L638
The bug described in moby/moby#35021 means Docker 17.09 incorrectly returns a 400 status code for name conflicts on container creation. This broke go-dockerclient's name conflict detection and thus our's.
A test amd64 linux build is attached.
nomad.gz