Configure Node GC Threshold #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -173,6 +173,8 @@ configured on client nodes. | |||
| sub-schedulers this server will handle. This can be used to restrict the | |||
| evaluations that worker threads will dequeue for processing. This | |||
| defaults to all available schedulers. | |||
| * `node_gc_threshold` This is a string with a unit suffix, such as "300ms", | |||
| "1.5h" or "25m". Valid time units are "ns", "us" (or "µs"), "ms", "s", "m", "h". Controls how "old" a node must be to be collected by GC | |||
There was a problem hiding this comment.
Would you mind formatting this to 80 characters. I would also reword the last sentence to something like: "Controls how long a node must be in a terminal state before it is garbage collected and purged from the system."
|
Small comment but looks great! |
|
Second time I forget about 80 characters will and rule to my linter. |
|
Awesome! Thanks so much! |
benbuzbee
pushed a commit
to benbuzbee/nomad
that referenced
this pull request
Jul 21, 2022
…shicorp#362) * issue358 Snapshot can attempt to delete a negative range from log * issue 358 change it to strict inequality
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #333