UI: Warn uncaught exceptions to console #3623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DingoEatingFuzz
force-pushed
the
f-ui-warn-uncaught-exceptions
branch
from
a133aed
to
935e08e
Compare
when developing the UI
DingoEatingFuzz
force-pushed
the
f-ui-warn-uncaught-exceptions
branch
from
935e08e
to
19d900e
Compare
mitchellh
approved these changes
Dec 6, 2017
| run.next(() => { | ||
| // eslint-disable-next-line | ||
| console.warn('UNRECOVERABLE ERROR:', this.get('error')); | ||
| }); |
There was a problem hiding this comment.
We need to steal this for TFE @thrashr888
|
It definitely works so far as it warns the error. Time will tell if that error is helpful enough to diagnose issues. |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI currently gracefully handles runtime exceptions, but it doesn't do much in the way of saying what, why, or how.
Now in the event of the gray screen of death, a stack trace is warned to the developer console.
However, production stack traces aren't very helpful, so I also wrote a short guide on how to run the UI in dev mode from source while proxying to a different Nomad cluster.