-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service registration for IPv6 docker addresses #3785
Comments
Hi @42wim, Thanks for the patch! I'm curious whether you're aware of additional address keys we might want to support? From the Docker docs it appears there's also secondary IP addresses and the link-local IPv6 address. I can't imagine anyone wanting to advertise the link-local IPv6 address, but perhaps the secondary addresses are useful? Either way a new top-level DockerDriverConfig field is the way to go. If we determine the IPv6 address is the only other useful address to advertise, a boolean like your label is probably ideal. Otherwise we'll probably want some sort of enum That would look something like the |
Personally I doubt anyone is using the SecondaryIP(v6)Addresses The link-locals, like you already said, aren't very useful for being registered to services. So I think the UseIPv6Address boolean would be good enough. If you agree with this conclusion, I'll make a PR :-) |
Thanks for digging into that @42wim! A boolean sounds good to me then. |
PR #3790 is added, also updated some documentation and just rebased again to master. |
This isn't working for me, when I view the addresses
Which shows that the container started by nomad has IP address Yet when I inspect the job allocation it shows empty
Here's the jobfile for this
|
Since you're using Unfortunately the only addresses in the CLI's status output are the ones assigned by Nomad's scheduler, not necessarily the address Docker assigns to the container. Now I'm not sure why the address is empty in your CLI output. Could you open a new issue with all the information in this comment as well as the interfaces and IP addresses on the host machine? The node status and network_interface configuration for the client is useful as well. Thanks! |
@schmichael roger that, I've made a very comprehensive issue here: #6412 Please check it out |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Hi, we're using nomad / consul in almost IPv6-only environments and are still using glidelabs/registrator to make our consul registrations. (just the basic docker bridge, not with any network overlays)
Since @schmichael #2709 PR has been merged, it's now also possible to have nomad register IPv6 container addresses with not much code change.
I made a simple patch 42wim@f991a0a and it seems to work fine. (easy to test in our env because only impacts nomad clients not servers)
This would also fix the ipv6 issues in #511, #1124 and #646 ;-)
I guess a better way is to add a
DockerDriverConfig
key to https://github.com/hashicorp/nomad/blob/master/client/driver/docker.go#L164, something likeUseIPv6Address
?Comments ?
The text was updated successfully, but these errors were encountered: