Heartbeat improvements and handling failures during establishing leadership #3890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug in which if the node attributes/meta changed, we would re-register the node in status initializing. This would incorrectly trigger the client to log that it missed its heartbeat. It would change the status of the Node to initializing until the next heartbeat occured.
…ing leadership establishment
|
Needs hashicorp/consul#3908 to be merged so it can be vendored |
armon
reviewed
Feb 21, 2018
nomad/heartbeat.go
Outdated
| // the race in which leadership is lost but a timer is created on this | ||
| // server since it was servicing an RPC during a leadership loss. | ||
| if !s.IsLeader() { | ||
| return |
There was a problem hiding this comment.
Should we log a message here, just to indicate that this happened?
|
LGTM! |
preetapan
approved these changes
Mar 5, 2018
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR are a result of going through logs of a cluster quickly transition between leaders. As such there are various semi-related fixes:
Fixes #3035
Fixes #3840