rkt: allow specifying --group #3990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmichael
force-pushed
the
f-rkt-groups
branch
from
0a8c3f4
to
04b0ebc
Compare
|
(Build failures appear to be unrelated) |
dadgar
reviewed
Mar 16, 2018
client/driver/rkt_test.go
Outdated
| // WaitUntil we can determine the user/group redis is running as | ||
| expected := []byte(`redis-server *:6379 redis redis`) | ||
| testutil.WaitForResult(func() (bool, error) { | ||
| raw, code, err := resp.Handle.Exec(ctx, "/bin/bash", []string{"-c", "ps -eo args,uid,gid | grep ^redis"}) |
There was a problem hiding this comment.
I am a bit confused. It is asserting redis as the user and group?
schmichael
force-pushed
the
f-rkt-groups
branch
from
04b0ebc
to
eeaaa60
Compare
dadgar
approved these changes
Mar 16, 2018
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.