Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of Vault errors #4100

Merged
merged 3 commits into from
Apr 4, 2018
Merged

Improve handling of Vault errors #4100

merged 3 commits into from
Apr 4, 2018

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Apr 3, 2018

This PR does the following:

  1. Adds recoverable error handling to the Client when it fails to Unwrap a token.
  2. Adds better response validation that displays Warnings returned from Vault.
  3. Vendors in Don't swallow logical.Unwrap error vault#4258 which fixes an issue
    where Vault's api would swallow an error that could have resulted from the
    underlying network.

Fixes #4097

@dadgar dadgar merged commit 67552a9 into master Apr 4, 2018
@dadgar dadgar deleted the b-vault-no-auth branch April 4, 2018 00:23
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants