Improve help text when invalid arguments are given #4176
Conversation
nickethier
commented
Apr 18, 2018
•
nickethier
commented
| @@ -21,7 +21,7 @@ func TestDeploymentListCommand_Fails(t *testing.T) { | |||
| if code := cmd.Run([]string{"some", "bad", "args"}); code != 1 { | |||
| t.Fatalf("expected exit code 1, got: %d", code) | |||
| } | |||
| if out := ui.ErrorWriter.String(); !strings.Contains(out, cmd.Help()) { | |||
| if out := ui.ErrorWriter.String(); !strings.Contains(out, commandErrorText(cmd)) { | |||
There was a problem hiding this comment.
In the future you can switch this style of check to use https://godoc.org/github.com/stretchr/testify/require#Contains and save a couple lines. No need to go back through and change all of these though.
| // when an error is printed. | ||
| func commandErrorText(cmd NamedCommand) string { | ||
| return fmt.Sprintf("For additional help try 'nomad %s -help'", cmd.Name()) | ||
| } |
There was a problem hiding this comment.
Love the little helper func + utility interface.
|
Looks like one of those test failures is relevant: https://travis-ci.org/hashicorp/nomad/jobs/368271509#L2645 |
CHANGELOG: add line for #4176
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
