Fix issue where node connection map wasn't being pruned #4231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🏎 |
preetapan
reviewed
Apr 27, 2018
nomad/client_rpc.go
Outdated
| } | ||
| } | ||
|
|
||
| // If we just deleted the last conn, remove it from the map |
There was a problem hiding this comment.
If the last connection is deleted why is numConns ==1 and not 0?
schmichael
approved these changes
Apr 27, 2018
nomad/client_rpc.go
Outdated
|
|
||
| // If we just deleted the last conn, remove it from the map | ||
| if found && numConns == 1 { | ||
| delete(s.nodeConns, ctx.NodeID) |
There was a problem hiding this comment.
You could do the len check and deletion right in the for loop.
| @@ -40,6 +40,11 @@ func (s *Server) getNodeConn(nodeID string) (*nodeConnState, bool) { | |||
| } | |||
| } | |||
|
|
|||
| // Shouldn't happen but rather be safe | |||
There was a problem hiding this comment.
Can we dream up a reason this is possible? If not should we add a debug or trace log just in case it can help us find where an invariant is being broken.
preetapan
approved these changes
Apr 27, 2018
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4230