Add nil check before setting timeout on docker client #4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickethier
approved these changes
May 16, 2018
dadgar
reviewed
May 21, 2018
| @@ -1099,7 +1099,7 @@ func (d *DockerDriver) newDockerClient(timeout time.Duration) (*docker.Client, e | |||
| } | |||
| } | |||
|
|
|||
| if timeout != 0 { | |||
| if timeout != 0 && newClient != nil { | |||
There was a problem hiding this comment.
Will the err be set in this case? Otherwise if newClient is nil and the error is nil, it seems like the caller is susceptible to a NPE too
There was a problem hiding this comment.
Yes the error is always set if newClient is nil. I read through the methods that return a new dockerClient in
and it always returns an error if the client is nil.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4289