UI: Remodel task-group-deployment-summary to properly use PlacedCanaries #4325
Conversation
DingoEatingFuzz
force-pushed
the
b-ui-placed-canaries
branch
from
6a2e707
to
1f83916
Compare
|
|
||
| export default ApplicationSerializer.extend({ | ||
| normalize(typeHash, hash) { | ||
| hash.PlacedCanaryAllocations = hash.PlacedCanaries || []; |
There was a problem hiding this comment.
Do you need this if you are setting the defaultValue above? (or vice versa)
There was a problem hiding this comment.
defaultValue isn't invoked when the value is null (as opposed to undefined), so this is needed. I suppose the defaultValue in the model isn't strictly necessary, but I like that it kinda doubles as a type annotation.
| @@ -5,7 +5,8 @@ import { test } from 'qunit'; | |||
| import moment from 'moment'; | |||
| import moduleForAcceptance from 'nomad-ui/tests/helpers/module-for-acceptance'; | |||
|
|
|||
| const sum = (list, key) => list.reduce((sum, item) => sum + get(item, key), 0); | |||
| const sum = (list, key, getter = a => a) => | |||
| list.reduce((sum, item) => sum + getter(get(item, key)), 0); | |||
|
@johncowen The tests were passing previously, but that's because the fixture data was also modeled incorrectly. So the process went:
|
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
PlacedCanaries is a
[]stringof allocation IDs, not anint.The result of the UI getting this wrong was whenever the count of placed canaries was shown, it was 0. Now it uses the length of PlacedCanaries.