Fix for dynamically reloading vault #4395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadgar
approved these changes
Jun 7, 2018
command/agent/command.go
Outdated
| c.agent.logger.Printf("[ERR] agent: failed to convert server config: %v", err) | ||
| if s := c.agent.Server(); s != nil { | ||
| sconf, err := convertServerConfig(newConf, c.logOutput) | ||
| c.agent.logger.Printf("[DEBUG] agent: starting reload of server config") |
There was a problem hiding this comment.
Can you move this to line 750 (above s.Reload)
nomad/vault_test.go
Outdated
| @@ -437,6 +437,31 @@ func TestVaultClient_SetConfig(t *testing.T) { | |||
| if client.tokenData == nil || len(client.tokenData.Policies) != 3 { | |||
| t.Fatalf("unexpected token: %v", client.tokenData) | |||
| } | |||
|
|
|||
| // test that when SetConfig is called with the same configuration, it is a | |||
Xopherus
added a commit
to Xopherus/nomad
that referenced
this pull request
Nov 11, 2019
Xopherus
added a commit
to Xopherus/nomad
that referenced
this pull request
Nov 11, 2019
Xopherus
added a commit
to Xopherus/nomad
that referenced
this pull request
Nov 11, 2019
Xopherus
added a commit
to Xopherus/nomad
that referenced
this pull request
Nov 12, 2019
Xopherus
added a commit
to Xopherus/nomad
that referenced
this pull request
Nov 12, 2019
Xopherus
added a commit
to Xopherus/nomad
that referenced
this pull request
Nov 12, 2019
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for dynamically reloading Vault configuration for Nomad. Further refactoring is needed to push logic into the client/server and out of the agent.