Certificate not reloaded on SIGHUP for dev agents

[schmichael]

Nomad version

Nomad v0.9.0-dev

350c836

for dev agents only

Regular clients and servers handle SIGHUP correctly.

Issue

Reproduction steps

Run nomad agent -dev -config tlsagent.hcl in the root of the nomad repo with the following tlsagent.hcl file:

tls {
  http = true
  rpc  = true

  ca_file   = "demo/tls/ca.pem"
  cert_file = "demo/tls/dev.pem"
  key_file  = "demo/tls/dev-key.pem"
}

Verify the certificates reported by the agent are the same as those on disk:

$ openssl x509 -in demo/tls/dev.pem -noout -text | grep 'Nomad Demo'
        Issuer: C=US, ST=CA, L=San Francisco, OU=Nomad Demo, CN=example.nomad
        Subject: C=US, ST=CA, L=San Francisco, OU=Nomad Demo

$ openssl s_client -connect localhost:4646 | grep 'Nomad Demo'
...
 0 s:/C=US/ST=CA/L=San Francisco/OU=Nomad Demo
   i:/C=US/ST=CA/L=San Francisco/OU=Nomad Demo/CN=example.nomad
...

Then copy new certificates over the configured one:

cp helper/tlsutil/testdata/ca.pem demo/tls/ca.pem
cp helper/tlsutil/testdata/nomad-foo.pem demo/tls/dev.pem
cp helper/tlsutil/testdata/nomad-foo-key.pem demo/tls/dev-key.pem

$ openssl x509 -in demo/tls/dev.pem -noout -text | grep CN=
        Issuer: C=US, ST=California, L=San Francisco, O=HashiCorp, OU=Nomad, CN=nomad.hashicorp
        Subject: C=US, ST=California, L=San Francisco, O=HashiCorp, OU=Nomad, CN=regionFoo.nomad

Send SIGHUP to the nomad PID and see that the original certificate is still in place:

$ openssl s_client -connect localhost:4646 | grep CN=
...
   i:/C=US/ST=CA/L=San Francisco/OU=Nomad Demo/CN=example.nomad
issuer=/C=US/ST=CA/L=San Francisco/OU=Nomad Demo/CN=example.nomad

Expected CN=regionFoo.hashicorp but found the old example.nomad

Nomad Client logs (if appropriate)

Sending SIGHUP logs the following:

==> Caught signal: hangup
==> Reloading configuration...
    2018/06/12 18:45:26.264697 [DEBUG] agent: starting reload of server config

[chelseakomlo]

Fixed in #4476

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.